feat(signups): embed now displays coordinator selected prog point #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 53.23% 53.04% -0.19%
==========================================
Files 70 70
Lines 3661 3674 +13
Branches 185 185
==========================================
Hits 1949 1949
- Misses 1712 1725 +13 ☔ View full report in Codecov by Sentry. |
ssilve1989
added a commit
that referenced
this pull request
May 16, 2024
🤖 I have created a release *beep* *boop* --- ## [1.6.0](v1.5.0...v1.6.0) (2024-05-16) ### Features * **signups:** embed now displays coordinator selected prog point ([#273](#273)) ([9bbd5b7](9bbd5b7)) ### Bug Fixes * adjusts labels for certain encounters ([#274](#274)) ([af49fc3](af49fc3)) * assign correct sentry scoping ([#272](#272)) ([f38d1e1](f38d1e1)) * fixes lost punctiation in display formatting ([#270](#270)) ([9eb9ac7](9eb9ac7)), closes [#266](#266) * revert typo for time duration ([8ce8ef9](8ce8ef9)) * **signups:** ensure prog links are validated when screenshots are provided ([#275](#275)) ([c365021](c365021)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request
Have final approval/rejection embed display prog point selected by coordinator from drop down instead of prog point progger initially input for BOTH approval channel and sign-up channel
Solution
If a prog point is defined (the coordinator picked one and the DM did not time out) it will be used to update the field on the embed seen in the appropriate channels